Repository navigation
chore: prep 0.1.7 release, and correct the README's slideshow docs - #41
Merged
Merged
Conversation
Three things were wrong. The tmux paragraph still described the alternate-screen rebuild as what every slide change does, with its flash presented as the price of reliability. That was replaced by the `tmux refresh-client` repaint, which costs nothing visible; the rebuild now runs only where a repaint cannot reach -- GNU screen, and tmux nested in another multiplexer -- and when `r` asks for it. The transmission verification is independent of either and now reads as its own point rather than a parenthesis inside the flash's justification. The key table claimed PgUp and PgDn were aliases for Home and End. They navigate by one slide, not to the ends: `page_keys_navigate` asserts `CSI 5~` is Prev and `CSI 6~` is Next. Anyone taking the table at its word would have thought the keys broken. Ctrl-D quits and was undocumented. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Version to 0.1.7 in Cargo.toml and both lockfiles' kittyview entries, the changelog's upcoming section becomes the 0.1.7 section, and the README and SECURITY.md verification examples pin the new tag. The one change: slideshow images render fully under tmux without the inter-slide flash, by repainting the client with `tmux refresh-client` instead of rebuilding through the pane's main screen. The probe variants that isolated it ship with it. Lockfiles were regenerated with `cargo update -p kittyview` rather than hand-edited, so neither picked up unrelated dependency churn. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe release metadata and verification examples now use version 0.1.7. The README also documents updated slideshow controls and repaint behavior for tmux and Ghostty. ChangesVersion 0.1.7 release updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This release updates version metadata and documents slideshow controls and terminal repaint behavior; it is ready to merge with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit reads each line, Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things, since the second is what the first releases.
1. README corrections
Checking the README against the slideshow changes turned up three errors, one of them ours and two pre-existing.
The tmux paragraph was ours, and now wrong. It described the alternate-screen rebuild as what every slide change does, with its flash presented as the price of reliability. #40 replaced that with the
tmux refresh-clientrepaint, which costs nothing visible. Rewritten: the repaint is the normal path, the rebuild is the fallback where a repaint cannot reach (GNU screen, nested tmux) or whenrasks for it, and the transmission verification now reads as its own point rather than a parenthesis inside the flash's justification. The ghostty#13056 reference is kept and folded in -- the wrong-size rendering it tracks is the same defect the repaint works around.The key table claimed PgUp/PgDn were aliases for Home/End. They are not -- they navigate by one slide:
page_keys_navigatehas asserted this all along. Anyone taking the table at its word would have thought the keys broken. This predates #40.Ctrl-D quits and was undocumented (
0x03 | 0x04 | b'q' | b'Q' => Key::Quit).2. Release prep
Patch bump -- one bug fix plus the test tooling that found it. Following
3f60d56(the 0.1.6 prep) exactly:Cargo.toml0.1.6->0.1.7(the release workflow gates the tag on this)Cargo.lock,fuzz/Cargo.lock0.1.7CHANGELOG.md## upcomingbecomes## 0.1.7README.md,SECURITY.md--source-ref refs/tags/pins tov0.1.7(1 + 2 occurrences)Both lockfiles were regenerated with
cargo update -p kittyviewrather than hand-edited; the diff is one line each, with no unrelated dependency churn.Verification
kittyview --versionreports0.1.7-- the check the v0.1.4 incident was about, where the tag shipped binaries reporting0.1.3## upcomingsection and norefs/tags/v0.1.6pins remainAfter merge
This only preps the release. Publishing still needs the
v0.1.7tag pushed, which is what triggersrelease.yml; the workflow re-checks the tag againstCargo.tomlbefore building anything.🤖 Generated with Claude Code
Summary by CodeRabbit
Release
Documentation