This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Repository navigation
ensure: Make -no-vendor combined with -dry-run fail when Gopkg.lock is outdated - #1256
Merged
Merged
Conversation
Contributor
Author
|
Could someone restart the appveyor run? It seems to have failed randomly. |
sdboyer
suggested changes
Oct 12, 2017
Member
There was a problem hiding this comment.
seems good! but, needs a test case 😄
Contributor
Author
|
Added tests |
sdboyer
approved these changes
Oct 17, 2017
sdboyer
approved these changes
Oct 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
It makes
dep ensure -no-vendor -dry-runfail when changes would be made toGopkg.lock.What should your reviewer look out for in this PR?
This is my first PR so I'm not sure if everything is up to standards.
Do you need help or clarification on anything?
No.
Which issue(s) does this PR fix?
fixes #950