Repository navigation
Conversation
…e cleared CoreJarVirtualFile does not override equals or hashCode and relies on object identity within a single CoreJarHandler instance. If CoreJarFileSystem.clearHandlersCache() is called while a LibraryRootsSearchScope is still in use (e.g. during concurrent in-process KSP executions), subsequent JAR lookups recreate CoreJarHandler and CoreJarVirtualFile instances, causing rootFiles.contains(current) to return false. Keep rootFiles for fast reference-identity checks and fall back to checking rootUrls when traversal reaches the top-level root (current.parent == null). Fixes google#3286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreJarVirtualFile does not override equals or hashCode and relies on object identity within a single CoreJarHandler instance. If CoreJarFileSystem.clearHandlersCache() is called while a LibraryRootsSearchScope is still in use (e.g. during concurrent in-process KSP executions), subsequent JAR lookups recreate CoreJarHandler and CoreJarVirtualFile instances, causing rootFiles.contains(current) to return false.
Keep rootFiles for fast reference-identity checks and fall back to checking rootUrls when traversal reaches the top-level root (current.parent == null).
Fixes #3286