Repository navigation
Fix getting annotation default values in KLibs - #3200
Merged
Merged
Conversation
jaschdoc
force-pushed
the
annotation-default-values
branch
2 times, most recently
from
September 8, 2026 14:39
f3e8490 to
32c66f3
Compare
jaschdoc
marked this pull request as ready for review
September 8, 2026 14:39
jaschdoc
enabled auto-merge
September 8, 2026 14:39
jaschdoc
force-pushed
the
annotation-default-values
branch
from
September 9, 2026 08:25
32c66f3 to
9b7732b
Compare
jaschdoc
marked this pull request as draft
September 9, 2026 08:28
auto-merge was automatically disabled
September 9, 2026 08:28
Pull request was converted to draft
jaschdoc
force-pushed
the
annotation-default-values
branch
from
September 9, 2026 08:45
9b7732b to
b310ac3
Compare
jaschdoc
marked this pull request as ready for review
September 9, 2026 09:24
jaschdoc
enabled auto-merge
September 9, 2026 10:34
troelsbjerre
reviewed
Sep 9, 2026
troelsbjerre
reviewed
Sep 9, 2026
jaschdoc
force-pushed
the
annotation-default-values
branch
3 times, most recently
from
September 14, 2026 12:20
f0a1922 to
63928d2
Compare
jaschdoc
force-pushed
the
annotation-default-values
branch
from
September 15, 2026 12:49
63928d2 to
df7a7c0
Compare
jaschdoc
marked this pull request as draft
September 18, 2026 12:16
auto-merge was automatically disabled
September 18, 2026 12:16
Pull request was converted to draft
The implementation deserializes the KLib and inspects the FIR AST to obtain the default annotation value.
jaschdoc
force-pushed
the
annotation-default-values
branch
from
September 21, 2026 08:37
df7a7c0 to
a001eb4
Compare
jaschdoc
marked this pull request as ready for review
September 21, 2026 0
8000
9:34
jaschdoc
enabled auto-merge
September 21, 2026 09:34
troelsbjerre
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to load in a KLib in
KaValueParameterSymbol.getDefaultValue()and inspect the FIR to obtain the default value. This PR also refactors the function into separate branches so it's clearer to read.Depends on #3199
Closes #2356