Add GetAllCustomPropertyValues for repositories #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
gmlewis
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Thank you, @liaodaniel !
Just a few tweaks, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3020 +/- ##
=======================================
Coverage 97.91% 97.92%
=======================================
Files 150 151 +1
Lines 12980 12993 +13
=======================================
+ Hits 12710 12723 +13
Misses 192 192
Partials 78 78 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
|
Thank you @gmlewis, need to pay more attention to copying and pasting 😅 |
gmlewis
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Thank you, @liaodaniel !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
Thank you, @valbeat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3014.
Signed-off-by: Daniel Liao 10663736+liaodaniel@users.noreply.github.com