Implement Custom Properties #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2986 +/- ##
==========================================
+ Coverage 98.11% 98.13% +0.01%
==========================================
Files 149 150 +1
Lines 12808 12906 +98
==========================================
+ Hits 12567 12665 +98
Misses 166 166
Partials 75 75
|
gmlewis
requested changes
Nov 4, 2023
There was a problem hiding this comment.
Thank you, @liaodaniel!
Just a few minor tweaks, please, and then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
gmlewis
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Thank you, @liaodaniel !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Also, can you please switch this PR out of "Draft" mode when you are ready?
|
Thank you, @valbeat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2965