8000 feat: Add missing GitHub App permissions to InstallationPermissions by vibbix · Pull Request #4703 · google/go-github · GitHub
[go: up one dir, main page]

Skip to content

feat: Add missing GitHub App permissions to InstallationPermissions - #4703

Open
vibbix wants to merge 2 commits into
google:masterfrom
vibbix:feature/installation-permissions-missing-scopes
Open

vibbix wants to merge 2 commits into
google:masterfrom
vibbix:feature/installation-permissions-missing-scopes

Conversation

@vibbix
@vibbix vibbix commented Nov 6, 2026 •
Copy link
Copy Markdown

Summary

As part of work for integrations/terraform-provider-github#3721 I needed to pull in some new fields into this provider.

InstallationPermissions has no field for eight permissions GitHub now returns, so callers can't read them off an app or installation, and can't request them when scoping down an installation token.

Six are in the app-permissions schema of GitHub's OpenAPI description: artifact_metadata, code_quality, custom_properties_for_organizations, organization_copilot_agent_settings, organization_copilot_requests and organization_external_properties_for_repos. The other two, repository_creation and installation_repositories, were announced in the October 13 changelog and aren't in the OpenAPI description yet.

How this was tested

Accessors and their tests come from script/generate.sh. script/test.sh and script/lint.sh pass.

AI Disclosure

Claude 5.5 @ High helped triage this

@vibbix
vibbix marked this pull request as ready for review November 6, 2026 17:42
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 6, 2026
@codecov
codecov Bot commented Nov 6, 2026
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (dac8c26) to head (1ecc43d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4703   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         204      204           
  Lines       19080    19080           
=======================================
  Hits        18822    18822           
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0