Repository navigation
Implement proxy interface for @AssistedFactory in FastInit mode. - #5346
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
In FastInit mode, when an `@AssistedFactory` interface or return type is package-private or Kotlin internal, Dagger's component (which may be in a different package) cannot directly instantiate an anonymous implementation of the factory. To fix this Dagger generates `[FactoryName]_Proxy`, an interface in the factory's package containing: - An abstract proxy method with inaccessible types erased to `Object` - A public static `createFactory([FactoryName]_Proxy proxy)` helper method returning the factory implementation masked The generated Component in FastInit mode delegates to `[FactoryName]_Proxy.createFactory(...)` using an anonymous proxy implementation that doesn't require referencing the non-public types. RELNOTES=Add assisted factory proxy to bypass visibility issues PiperOrigin-RevId: 1018206561
copybara-service
Bot
force-pushed
the
test_1018206561
branch
from
November 17, 2026 20:56
b6e20e2 to
8721f8e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement proxy interface for
@AssistedFactoryin FastInit mode.In FastInit mode, when an
@AssistedFactoryinterface or return type is package-private or Kotlininternal, Dagger's component (which may be in a different package) cannot directly instantiate
an anonymous implementation of the factory.
To fix this Dagger generates
[FactoryName]_Proxy, an interface in the factory's package containing:ObjectcreateFactory([FactoryName]_Proxy proxy)helper method returning the factory implementation maskedThe generated Component in FastInit mode delegates to
[FactoryName]_Proxy.createFactory(...)using an anonymous proxy implementation that doesn't require referencing
the non-public types.
RELNOTES=Add assisted factory proxy to bypass visibility issues