Repository navigation
Use XPropertyElement.hasInaccessibleAnnotations() instead of parsing Kotlin metadata. - #5337
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_995869306
branch
4 times, most recently
from
November 5, 2026 08:11
32f5e36 to
c062d01
Compare
…Kotlin metadata. Dagger and Hilt still parse `@kotlin.Metadata` themselves for one thing: detecting when a Kotlin property's synthetic `$annotations` method is missing, which happens for properties of classes from other compilations (https://youtrack.jetbrains.com/issue/KT-34684). XProcessing now exposes this as `XPropertyElement.hasInaccessibleAnnotations()`, so use that and delete `ClassMetadata`, `KotlinMetadata`, and `KotlinMetadataFactory` from both compilers. RELNOTES=N/A PiperOrigin-RevId: 1014467854
copybara-service
Bot
force-pushed
the
test_995869306
branch
from
November 5, 2026 08:34
c062d01 to
9ff246c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use XPropertyElement.hasInaccessibleAnnotations() instead of parsing Kotlin metadata.
Dagger and Hilt still parse
@kotlin.Metadatathemselves for one thing: detecting when a Kotlin property's synthetic$annotationsmethod is missing, which happens for properties of classes from other compilations (https://youtrack.jetbrains.com/issue/KT-34684). XProcessing now exposes this asXPropertyElement.hasInaccessibleAnnotations(), so use that and deleteClassMetadata,KotlinMetadata, andKotlinMetadataFactoryfrom both compilers.RELNOTES=N/A