Repository navigation
fix(artifacts): encode filenames in artifact request URLs - #560
Merged
copybara-service[bot] merged 2 commits intoNov 6, 2026
Merged
copybara-service[bot] merged 2 commits into
copybara-service[bot] merged 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ArtifactService interpolates artifact filenames directly into request URLs. For example,
report#1.jsonbecomes a URL fragment, andreport?draft.jsonbecomes a query string, so the backend receives a different filename. Literal percent signs can also be interpreted as URL escapes.Change
Encode the artifact filename as a URL path component in both latest-artifact and version-specific requests. Add twelve regression cases with literal expected URLs covering
#,?,%, literal percent escapes, user-scoped paths, and Unicode/spaces across both endpoints; existing ordinary-filename tests remain in place.Validation
git diff --checkpasses.npm run build); dependency optimization/bundle-size warnings remain. An earlier attempt hit local disk exhaustion; the retry completed successfully.{artifact_name:path}and pass the decoded filename to the artifact service. This is source inspection, not a live backend end-to-end test.Searched existing issues and open/closed PRs for artifact filename encoding and found no matching fix. This is separate from the UTF-8 artifact-preview fixes.