Repository navigation
fix(chat): route A2UI button actions to the agent - #558
Open
huong8373tt-beep wants to merge 1 commit into
Open
huong8373tt-beep wants to merge 1 commit into
huong8373tt-beep wants to merge 1 commit into
Conversation
Author
|
Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content. Generated with AI assistance and refined through human review. |
Author
|
The implementation and focused regression test are complete and the PR is ready for maintainer review. The remaining Angular Tests workflow is currently waiting for repository-side action approval; no code or test failure has been reported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #557.
A2UI v0.8 button actions were dispatched by
MessageProcessor, butadk-webdid not subscribe to its events. As a result, the action was dropped and the dispatch promise never settled.This change subscribes once from
ChatComponent, serializes eachuserActionas a user turn through the existingsendMessage()//run_ssepath, completes the A2UI dispatch only after the turn is accepted, propagates send failures to the dispatch completion, and unsubscribes during component destruction.Validation
npm run build— passedchat.component.spec.ts— 134 tests passed; the Windows Karma/ChromeHeadless process did not exit cleanly after reporting success, so the outer job had to be cancelled.git diff --check— passedDisclosure
Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.
Generated with AI assistance and refined through human review.