8000 fix(chat): persist session state edits on save by OKAN-SOFTWARE · Pull Request #556 · google/adk-web · GitHub
[go: up one dir, main page]

Skip to content

fix(chat): persist session state edits on save - #556

Open
OKAN-SOFTWARE wants to merge 2 commits into
google:mainfrom
OKAN-SOFTWARE:fix/401-update-session-state
Open

OKAN-SOFTWARE wants to merge 2 commits into
google:mainfrom
OKAN-SOFTWARE:fix/401-update-session-state

Conversation

@OKAN-SOFTWARE
Copy link
Copy Markdown

Summary

  • Persist session state changes immediately when the Update State dialog is saved.
  • Use the existing session PATCH endpoint to send the updated state.
  • Refresh the session state after successful persistence.
  • Display an error notification if the update fails.
  • Preserve pending updates when no session has been created.

Regression Tests

Added four tests covering:

  • Saving updated session state
  • Canceling the dialog
  • Updating state before session creation
  • Handling API failures

Validation

  • Angular tests: 829 passed, 37 skipped
  • Production build: Passed
  • Git whitespace validation: Passed

Scope

This change addresses the session-state persistence problem described in #401.

State-key deletion and the separately reported button-color issue are outside the scope of this fix.

Related to #401.

@google-cla
google-cla Bot commented Oct 29, 2026
Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0