Repository navigation
fix: preserve SSE events across chunk boundaries - #555
Open
Linxiushen wants to merge 1 commit into
Open
Linxiushen wants to merge 1 commit into
Linxiushen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
When a fetch chunk contains a complete SSE event followed by only part of the next event,
runSsereplays the first event on the next read. A chunk boundary inside thedata:prefix can also drop an event entirely. Following the line-buffering approach suggested in #113, keep only the unfinished line between reads and process each complete data line once. A malformed, newline-terminated JSON payload now reaches the existing observable error handler instead of being treated as an unfinished chunk.Regression coverage includes batched complete/partial events, a split
data:prefix, single-byte UTF-8/CRLF chunks, and invalid complete JSON with loading-state cleanup.Validation:
npm run test -- --no-watch --no-progress --browsers=ChromeHeadlessCI --include=src/app/core/services/agent.service.spec.ts: 21 passed.npm run build: passed.Tests ran on Windows with headless Chromium; no manual browser testing is claimed.
Developed with AI assistance (Codex).