Repository navigation
fix: open external chat links in a new tab - #541
Merged
copybara-service[bot] merged 1 commit intoNov 4, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what a
6DB2
ppears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking an HTTP/HTTPS link in a chat response navigates away from ADK web. Open these links in a new tab with
target="_blank"andrel="noopener noreferrer"after each sanitized Markdown render, including streamed message updates.Preserve existing relation tokens and leave relative, fragment, and email links unchanged. The change uses the Markdown component's render-completion event and keeps Angular's sanitization enabled.
Fixes #546
Validation
npm test -- --no-watch --no-progress --browsers=ChromeHeadlessCI: 781 passed, 37 skipped.npm run build: passed with dependency optimization warnings.git diff --check: passed.