Repository navigation
fix(chat): display human input replies in the transcript - #539
Open
jabrailkhalil wants to merge 2 commits into
Open
jabrailkhalil wants to merge 2 commits into
jabrailkhalil wants to merge 2 commits into
Conversation
Author
|
Resolved the current-main integration conflicts in 84343f9. Human input replies still render as literal user text / complete structured JSON, while main’s grounding sources, tool-confirmation cards and file/web-tool response displays are preserved. The response chip and its original details remain available. Fresh Windows validation: full ChromeHeadlessCI suite 832 passed / 37 skipped / 0 failed, application and test TypeScript checks passed, and production build passed. The seven existing human-input regression cases remain unchanged. This is browser-component validation, not a live backend round trip. Could a maintainer review the new head and approve the pending upstream test workflow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human replies submitted through the inline
adk_request_inputform currently appear only as a function-response chip, so the transcript hides what the person actually answered.I now display the persisted answer as a user bubble while keeping the existing chip and its full response details. Free-text replies remain literal text; structured form answers are displayed as JSON without dropping fields. This applies to replies loaded from session history as well as newly submitted replies, and leaves other tool responses unchanged.
Refs google/adk-js#732.
Validation:
84343f9, integrating maindfac466: full Angular suite in Chrome Headless on Windows: 832 passed, 37 skipped, 0 failed. Application and test TypeScript checks pass; production build passes. Upstream test workflow approval/review remain required.npm run build.The October 10 merge keeps current-main grounding sources, confirmation cards and file/web-tool displays together with human replies; no new feature scope or test relaxations were added. Validation is limited to browser components, not a live backend round trip.