8000 Don't require USE_ADC_CREDENTIALS=1 to run tests. by tylere · Pull Request #220 · google/Xee · GitHub
[go: up one dir, main page]
Skip to content

Don't require USE_ADC_CREDENTIALS=1 to run tests. - #220

Merged
copybara-service[bot] merged 3 commits into
google:mainfrom
tylere:main
Feb 11, 2025
Merged

Don't require USE_ADC_CREDENTIALS=1 to run tests.#220
copybara-service[bot] merged 3 commits into
google:mainfrom
tylere:main

Conversation

@tylere
@tylere tylere commented Feb 4, 2025
Copy link
Copy Markdown
Contributor

Instead use ADC credentials if GOOGLE_APPLICATION_CREDENTIALS does not exist. This allows tests to be run without setting an environment variable, which is required by VSCode's Testing (test discovery and management).

@tylere
Don't require USE_ADC_CREDENTIALS=1 to run tests.
c3f4a3d 
Instead use ADC credentials if GOOGLE_APPLICATION_CREDENTIALS does not
exist. This allows tests to be run without setting an environment
variable, which is required by VSCode's Testing (test discovery and
management).
@tylere
tylere requested review from jdbcode and naschmitz February 4, 2025 18:12
naschmitz
naschmitz requested changes Feb 4, 2025
View reviewed changes
@naschmitz naschmitz left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. Could you also update https://github.com/google/Xee?tab=readme-ov-file#how-to-run-integration-tests?

@jdbcode
jdbcode removed their request for review February 4, 2025 19:05
@tylere
tylere commented Feb 7, 2025 •
edited
Loading
Copy link
Copy Markdown
Contributor Author

The automated tests are failing with

Error: google-github-actions/auth failed with: retry function failed after 4 attempts: the GitHub Action workflow must specify exactly one of "workload_identity_provider" or "credentials_json"! If you are specifying input values via GitHub secrets, ensure the secret is being injected into the environment. By default, secrets are not passed to workflows triggered from forks, including Dependabot.

I don't have access to the repo secrets. @naschmitz could you look at this?

@naschmitz
naschmitz commented Feb 10, 2025
Copy link
Copy Markdown
Collaborator

The automated tests are failing with

Error: google-github-actions/auth failed with: retry function failed after 4 attempts: the GitHub Action workflow must specify exactly one of "workload_identity_provider" or "credentials_json"! If you are specifying input values via GitHub secrets, ensure the secret is being injected into the environment. By default, secrets are not passed to workflows triggered from forks, including Dependabot.

I don't have access to the repo secrets. @naschmitz could you look at this?

I think this is because the integration tests are running on a fork. We should be good to submit it.

@jdbcode
Update README.md
4cfb6cf 
Formatted README.md to *hopefully* pass mdlint
@copybara-service
copybara-service Bot merged commit b1c6f13 into google:main Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naschmitz naschmitz naschmitz approved these changes

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tylere @naschmitz @jdbcode
0