Repository navigation
fix(e2e): set required spec.stability on KinD E2E Component CRs - #1564
Merged
Merged
Conversation
#1540 made spec.stability a required field in the Component CRD. The Playwright E2E CMS reconciliation check and the Go KinD harnesses apply Component CRs without it, which the API server now rejects ("spec.stability: Required value"), breaking the KinD & Playwright Headless E2E merge-queue job. Set stability to STABLE on these test fixtures; STABLE avoids the acknowledgeExperimental CEL rule and CMS STABILITY_INVERSION checks which these tests do not target. TAG=agy CONV=076b9660-2c35-402b-bd1f-2beb667902d7
There was a problem hiding this comment.
Code Review
This pull request updates several end-to-end test files, including components_lifecycle_e2e_test.go, kind_3p_harness_test.go, and test_e2e_flow.py, to include a "stability": "STABLE" field in the component specifications. There are no review comments to address, and I have no additional feedback to provide.
VLukiantsev
marked this pull request as ready for review
November 3, 2026 13:16
VLukiantsev
enabled auto-merge
November 3, 2026 13:16
janzak-dev
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the KinD & Playwright Headless E2E failure on
mainby setting the now-requiredspec.stabilityfield on Component CRs applied by the E2E suites.Motivation & Context
#1540 made
spec.stabilitya required field (enumEXPERIMENTAL/PREVIEW/STABLE) in the Component CRD. The Playwright E2E stage[6/6] Verifying Authenticated xmc-bridge -> CMS Reconciliationapplies an inlinee2e-cms-auth-checkComponent without it, so the API server rejects it:Failing run: https://github.com/google/xmc/actions/runs/41634507535/job/125914638219
The Go KinD harnesses install the same CRD from
deploy/helm/templates/components/crd.yamland build Component specs withoutstability, so they are fixed in the same PR.Key Changes
test/e2e/test_e2e_flow.py: add"stability": "STABLE"to thee2e-cms-auth-checkComponent manifest.test/e2e/components_lifecycle_e2e_test.go: addstability: STABLEinapplyLifecycleComponent.test/e2e/kind_3p_harness_test.go: addstability: STABLEto the 3P wrapper Component spec.Assumptions
STABLEis the right tier for these test fixtures — it avoids theacknowledgeExperimentalCEL rule and CMSSTABILITY_INVERSIONchecks, which these tests do not target — if wrong, stability-specific coverage would need dedicated test cases instead.deploy/profiles/stable-2026a/components/{clickhouse,redpanda}/README.mdalso omitstability; left out of scope as doc drift unrelated to the CI failure.merge_grouprun is the verification.Verification & Testing
bazel build //test/e2e:components_lifecycle_test //test/e2e:kind_3p_harness_unit_test,bazel test //test/e2e:kind_3p_harness_unit_test,./.githooks/pre-commitkind_3p_harness_unit_testpasses; pre-commit hooks pass.Related Issues / Bugs
N/A
TAG=agy
CONV=076b9660-2c35-402b-bd1f-2beb667902d7