Repository navigation
fix(examples): eliminate managed_xprof startup race and align image name - #1502
Draft
CatherineF-dev wants to merge 1 commit into
Draft
CatherineF-dev wants to merge 1 commit into
CatherineF-dev wants to merge 1 commit into
Conversation
This was referenced Oct 30, 2026
There was a problem hiding this comment.
Code Review
This pull request refactors the XManager Cloud launch example to pre-create the ManagedXprof artifact before submitting work units with explicit IDs, eliminating startup races between the Actuator and the Diagon Reconciler. Additionally, the worker is updated to start the JAX profiler server only after programmatic tracing completes to prevent trace collisions. Feedback suggests wrapping the JAX profiler server startup in a try-except block to prevent port-binding failures from crashing the entire workload.
Comment on lines
+76
to
+77
| jax.profiler.start_server(profiler_port) | ||
| print(f"JAX profiler server listening on port {profiler_port}.", flush=True) |
There was a problem hiding this comment.
If the profiler port is already in use or another startup error occurs, start_server will raise an exception and crash the entire workload, even though programmatic tracing has already completed successfully. Wrapping start_server in a try-except block ensures the workload can continue running its remaining steps.
Suggested change
| jax.profiler.start_server(profiler_port) | |
| print(f"JAX profiler server listening on port {profiler_port}.", flush=True) | |
| try: | |
| jax.profiler.start_server(profiler_port) | |
| print(f'JAX profiler server listening on port {profiler_port}.', flush=True) | |
| except Exception as e: | |
| print(f'Failed to start JAX profiler server on port {profiler_port}: {e}. On-demand profiling will be unavailable.', flush=True) |
CatherineF-dev
force-pushed
the
fix/examples-managed-xprof-startup-race
branch
from
October 30, 2026 14:54
dec110a to
5e1f158
Compare
Creating a WorkUnit before attaching its EXECUTION-phase ManagedXprofArtifact
introduces a startup race where the initial Actuator scheduling pass or
Diagon Reconciler pass can run before display_name and run_group exist in
Experiment State Server. In addition, starting the on-demand JAX profiler
server on port 9999 before jax.profiler.stop_trace() completes allows
interactive captures to collide with an active programmatic trace session.
- Pre-create the EXECUTION-phase ManagedXprofArtifact under
experiments/{xid}/workUnits/{wid} before calling CreateWorkUnit with an
explicit work_unit_id={wid} via the public experiment_state_api client,
eliminating the startup race as well as misleading SDK/ESS warnings.
- Start jax.profiler.start_server(9999) after jax.profiler.stop_trace()
finishes in worker.py so on-demand captures cannot collide with an active
programmatic trace session.
- Align the default container image name from programmatic-xprof-job to
managed-xprof-artifact-job across build_and_push.sh, launch.py, and
.github/workflows/nightly-examples-e2e.yml.
TAG=agy
CONV=108bc446-88fa-4cbf-b70b-e3e5e9c917c5
CatherineF-dev
force-pushed
the
fix/verifier-managed-xprof-url
branch
from
October 30, 2026 15:18
d9de688 to
58889d2
Compare
CatherineF-dev
force-pushed
the
fix/examples-managed-xprof-startup-race
branch
from
October 30, 2026 15:18
5e1f158 to
f69d12e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack
fix(reconciler): cache mlrun urls across batch flush window and downgrade 409 logsfix(verifier): auto-validate managed_xprof xprof_url and honor expected_title_patternfix(examples): eliminate managed_xprof startup race and align image name👉 Current PRSummary
Eliminates the startup race in
examples/managed_xprof_artifact_jobby pre-registering theEXECUTION-phaseManagedXprofArtifactbefore creating eachWorkUnit, starts the on-demand JAX profiler server after programmatic tracing completes, and aligns the default container image name tomanaged-xprof-artifact-job.Motivation & Context
Creating a
WorkUnitbefore attaching itsManagedXprofArtifactallows the initial Actuator and Reconciler passes to run beforedisplay_nameandrun_groupexist in Experiment State Server. Startingjax.profiler.start_server(9999)beforejax.profiler.stop_trace()also risks concurrent on-demand capture collisions during programmatic tracing.Key Changes
examples/managed_xprof_artifact_job/launch.pyandREADME.mdto pre-create theEXECUTION-phaseManagedXprofArtifactunderexperiments/{xid}/workUnits/{wid}before callingCreateWorkUnit(work_unit_id=wid)viaexperiment_state_api.examples/managed_xprof_artifact_job/worker.pyto startjax.profiler.start_server(9999)afterjax.profiler.stop_trace()completes.programmatic-xprof-jobtomanaged-xprof-artifact-jobinbuild_and_push.sh,launch.py, and.github/workflows/nightly-examples-e2e.yml.Assumptions
None — requirements were fully specified.
Verification & Testing
./tools/run_affected_tests.py --skip-emulator-checkRelated Issues / Bugs
N/A
TAG=agy
CONV=108bc446-88fa-4cbf-b70b-e3e5e9c917c5