Repository navigation
feat(deploy): support optional in-cluster PostgreSQL deployment in Helm and Cluster Toolkit - #1497
Draft
andrzejfudro wants to merge 1 commit into
Draft
andrzejfudro wants to merge 1 commit into
andrzejfudro wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for an optional in-cluster PostgreSQL deployment as an alternative database backend to Spanner. It adds the necessary Helm templates (StatefulSet, Service, ConfigMap), helper functions, configuration values, and Python tests, while updating deployment tools to skip Spanner migrations when the PostgreSQL backend is active. The review feedback highlights two improvements in the PostgreSQL StatefulSet: executing pg_isready directly for probes to avoid shell overhead, and quoting the octal defaultMode value ("0755") to prevent YAML parsing issues that lead to incorrect file permissions.
andrzejfudro
force-pushed
the
feat/helm-ctk-postgres-deploy
branch
from
October 30, 2026 10:59
22ef2d3 to
548ccfd
Compare
andrzejfudro
force-pushed
the
feat/helm-ctk-postgres-deploy
branch
from
October 30, 2026 12:03
548ccfd to
0349d9c
Compare
andrzejfudro
force-pushed
the
feat/helm-ctk-postgres-deploy
branch
3 times, most recently
from
October 30, 2026 15:35
8bf051e to
36d0d46
Compare
…lm and Cluster Toolkit Add optional in-cluster Kubernetes PostgreSQL deployment (`database.postgres.deploy: true`) in `deploy/helm/` alongside existing Bring-Your-Own PostgreSQL (`database.postgres.deploy: false`), rendering a `ClusterIP` `Service`, idempotent multi-database `initdb` `ConfigMap`, and single-replica `StatefulSet` with optional password support (`POSTGRES_HOST_AUTH_METHOD: trust` when password is empty), auto-defaulted connection settings in `_helpers.tpl`, and `deploy_postgres` wiring in `deploy/ctk_v2/xmanager-cloud.yaml`. TAG=agy CONV=c378f400-74cf-40e8-a8aa-5f9f91ab0cb1
andrzejfudro
force-pushed
the
feat/helm-ctk-postgres-deploy
branch
from
October 30, 2026 16:05
36d0d46 to
47e5023
Compare
AntonTyb
approved these changes
Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
database.postgres.deploy: true, defaultfalsefor BYO) indeploy/helm/, rendering aClusterIPService, idempotent multi-databaseinitdbConfigMap, and single-replicaStatefulSetwith optional password support (POSTGRES_HOST_AUTH_METHOD: trustwhen password is empty).host,port,user,essDatabase,xidDatabase, andsslMode) in_helpers.tplanddb-config.yamlwhendatabase.postgres.deployistrue, preserving required settings andverify-fulldefault for BYO (deploy: false).deploy_postgres: trueindeploy/ctk_v2/xmanager-cloud.yamland wiredatabase.postgres.deployintoxmc_app_helm.test/helm/postgres_deploy_test.py) and Workload Identity parity coverage (test/helm/workload_identity_binding_test.py).Assumptions
TAG=agy
CONV=c378f400-74cf-40e8-a8aa-5f9f91ab0cb1