Repository navigation
refactor(components): promote component store to database-agnostic dbstore package - #1404
Merged
andrzejfudro merged 3 commits intoOct 29, 2026
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors and renames the production Cloud Spanner persistence driver package from spanner to dbstore (pkg/components/store/dbstore), renaming the SpannerStore struct to Store and updating all associated tests, build files, imports, and documentation. Feedback on these changes suggests updating an unimplemented error message in GetPlatformHealth to refer to Store instead of SpannerStore, and correcting a file path reference in the README.md to point to ownership_fence.go instead of fence.go.
andrzejfudro
force-pushed
the
refactor/promote-cms-store
branch
from
October 23, 2026 13:58
9be3002 to
f9f1c04
Compare
andrzejfudro
force-pushed
the
refactor/promote-cms-store
branch
from
October 26, 2026 10:14
f9f1c04 to
77b3754
Compare
andrzejfudro
force-pushed
the
refactor/promote-cms-store
branch
from
October 29, 2026 12:21
8f3fe9b to
714c678
Compare
…store package Rename pkg/components/store/spanner to pkg/components/store/dbstore, rename SpannerStore/NewSpannerStore to Store/New, and update experiment_state_server, health_service, and component documentation to import the database-agnostic dbstore package. TAG=agy CONV=5d43b8db-2f9c-4908-a311-376a2b7dfdf0
andrzejfudro
force-pushed
the
refactor/promote-cms-store
branch
from
October 29, 2026 12:39
714c678 to
0ffa88a
Compare
andrzejfudro
marked this pull request as ready for review
October 29, 2026 12:40
andrzejfudro
enabled stacked auto-merge
October 29, 2026 12:40
VLukiantsev
reviewed
Oct 29, 2026
VLukiantsev
reviewed
Oct 29, 2026
VLukiantsev
previously approved these changes
Oct 29, 2026
Collaborator
There was a problem hiding this comment.
LGTM — clean mechanical rename that matches the description; Bazel targets and callers are updated consistently. Left two non-blocking nits about stale SpannerStore references in comments.
…omote-cms-store # Conflicts: # cmd/experiment_state_server/main.go
Qualify store.Store in the dbstore compile-time assertion comment and update remaining SpannerStore / spanner_store.go references across test headers, store comments, and api/buf.yaml. Comment link: #1404 (comment) Comment link: #1404 (comment) TAG=agy CONV=5d43b8db-2f9c-4908-a311-376a2b7dfdf0
VLukiantsev
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote
pkg/components/store/spannerto the database-agnosticpkg/components/store/dbstorepackage (dbstore.Store/dbstore.New) now that all component queries, mutations, and transactions run throughstorage.Storage.Key Changes
dbstorePackage (pkg/components/store/dbstore): Movepkg/components/store/spannertopkg/components/store/dbstore, renamingSpannerStore/NewSpannerStoretoStore/Newwhile preserving Git rename similarity across all source and test files.cmd/experiment_state_server,cmd/health_service,pkg/components/README.md): PointinitCMS,HealthServiceLazySpannerWrapper.ComponentsProvider, Bazel targets, and package documentation atpkg/components/store/dbstore.Assumptions
pkg/components/store/dbstoretests still exercisedbstore.Storeagainst the Spanner emulator in this PR — making thedbstoretest harness backend-neutral across Spanner and PostgreSQL is split into the follow-up test PR in this stack —dbstore_testremains Spanner-emulator-backed until that follow-up lands.Verification
bazel test //pkg/components/... //cmd/experiment_state_server/... //cmd/health_service/... //internal/storage/...(Passed)./.githooks/pre-commit(Passed)TAG=agy
CONV=5d43b8db-2f9c-4908-a311-376a2b7dfdf0