Repository navigation
feat(ci): add example container image build step for nightly clickhouse metrics job - #1056
Merged
Merged
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
andrzejfudro
approved these changes
Oct 2, 2026
janzak-dev
marked this pull request as draft
October 2, 2026 10:07
janzak-dev
marked this pull request as ready for review
October 2, 2026 10:37
VLukiantsev
removed their request for review
October 2, 2026 10:38
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a
30D9
batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a dedicated prerequisite CI job
build-example-imagesinnightly-examples-e2e.ymlthat builds and pushes container images required by nightly example workloads before executing the test matrix, starting withclickhouse-metrics-job.Stack Context: Layer 1 of 3 (Prerequisite Image Build Step)
Note
This PR is Layer 1 (Base) of a 3-PR stack (GitHub Stack #1058):
feat/nightly-ci-build-example-images): Prerequisite Image Build Step. Introduces thebuild-example-imagesworkflow job to authenticate against GCP, configure Docker authentication for Artifact Registry, and build/pushclickhouse-metrics-job:latestbefore test execution.feat/nightly-unblocked-examples-suite): 7 Unblocked Example Verifiers & Matrix. Expands image building inbuild-example-images, introduces 6 workload verifiers undertools/nightly_tests/, addsvalidate_artifactshelper utilities and tests, and registers the 7 unblocked workloads in the nightly CI matrix.feat/nightly-remaining-examples-suite): Remaining Workloads Suite. Completes coverage across remaining example workloads.Motivation & Context
Nightly example verification workloads that execute custom container images (such as
clickhouse_metrics_job) require those images to be present in Artifact Registry. Running a build-and-push step prior to the matrix execution ensures the worker containers are up to date and eliminates missing image failures.Key Changes
build-example-imagesto.github/workflows/nightly-examples-e2e.ymlrunning onarc-runner-setwith Workload Identity Federation authentication and Artifact Registry Docker auth.us-docker.pkg.dev/${PROJECT_ID}/xmc/clickhouse-metrics-job:latestusingexamples/clickhouse_metrics_job/Dockerfile.run-and-verify-examplesto depend onbuild-example-images, and updatedreport-nightly-failureto alert on failure inbuild-example-images.Assumptions
None.
Verification & Testing
Build Example Container Imagessucceeded in 34s, followed by 100% green execution ofRun & Verify: ClickHouse Metrics Job(1m17s) andRun & Verify: Simple Job (3 Multi-Unit Batch)(2m34s)../.githooks/pre-commit).bazel test //tools/nightly_tests/...).Related Issues / Bugs
Part of the nightly E2E verification test suite stack (#1058).
TAG=agy
CONV=acf882de-1561-404c-ba2e-ae0940451165