Repository navigation
fix(ui): remediate dependabot alerts for qs (#108, #109) - #999
Merged
Merged
Conversation
Remediates Dependabot security alerts #108 and #109 in cmd/ui: - Alert #108: qs array-limit bypass via bracket-key comma parsing (GHSA-x5fp-wj9c-mxmx / CVE-2026-82562). - Alert #109: qs denial of service via attacker-controlled isBuffer (GHSA-4mjr-xmp4-gh2g / CVE-2026-82417). Pinned qs to 6.16.0 in cmd/ui/package.json overrides section and regenerated cmd/ui/package-lock.json. Verified npm audit reports 0 vulnerabilities and all 616 Angular UI unit tests pass cleanly. TAG=agy CONV=fb7961b5-20f2-48f7-8f4f-ae947323c084
There was a problem hiding this comment.
Code Review
This pull request removes the 'listr2' dependency and updates 'qs' to version '6.16.0' along with its transitive dependencies. However, 'qs' was added directly to the dependencies block in 'package.json' instead of an 'overrides' block, which is required to correctly override transitive dependencies as intended.
VLukiantsev
marked this pull request as ready for review
September 28, 2026 10:43
VLukiantsev
enabled auto-merge
September 28, 2026 10:43
AntonTyb
approved these changes
Sep 28, 2026
Collaborator
There was a problem hiding this comment.
any idea why dependabot did not open a PR for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates two open Dependabot security advisories (#108 and #109) in
cmd/uiby overriding transitive dependencyqsto patched version6.16.0.Motivation & Context
GitHub Dependabot identified two active security vulnerabilities in
cmd/uitargeting theqspackage (installed:6.15.2):qsarray-limit bypass via bracket-key comma parsing (Medium severity, fixed in6.16.0).qsDenial of Service via attacker-controlledisBuffer(Medium severity, fixed in6.16.0).Following repository precedent (e.g. PR #694), adding
"qs": "6.16.0"to theoverridessection ofcmd/ui/package.jsonupdates all transitive resolutions cleanly.Key Changes
cmd/ui/package.json: Added"qs": "6.16.0"to theoverridessection.cmd/ui/package-lock.json: Regenerated lockfile, updatingnode_modules/qsfrom6.15.2to6.16.0.Assumptions
None — requirements were fully specified.
Verification & Testing
npm auditinsidecmd/uiconfirmed 0 vulnerabilities.npm run buildcompiled the Angular UI bundle successfully with 0 errors.npm run lintandnpm run format:checkpassed cleanly.python3 cmd/ui/run_ui_tests.pyran all 616 Angular UI unit tests with 100% success (TOTAL: 616 SUCCESS).python3 tools/analyze_diff_size.py --base-ref origin/main...verified 2 production code lines modified (well below the 400-line threshold)../.githooks/pre-commitpassed all linter and formatting checks.Related Issues / Bugs
TAG=agy
CONV=fb7961b5-20f2-48f7-8f4f-ae947323c084