Repository navigation
fix(deploy,examples): pin googleapis-common-protos below 1.75.4 - #985
Merged
Merged
Conversation
…solve proto descriptor pool breakage Pin googleapis-common-protos to <1.75.4 across deployment scripts, example requirements, and SDK configs. Upstream 1.75.4 regenerated operations_proto_pb2.py from operations_proto.proto instead of operations.proto, breaking descriptor pool lookup for google/longrunning/operations.proto. TAG=agy CONV=df3c1c34-924a-42d3-81dc-9755d79b93f5
janzak-dev
temporarily deployed
to
xmc-nightly
September 25, 2026 07:34 — with 
GitHub Actions
Inactive
There was a problem hiding this comment.
Code Review
This pull request updates the googleapis-common-protos dependency across multiple project files to include a version constraint of <1.75.4. The reviewer suggests standardizing dependency installation by using requirements.txt files instead of manually listing packages in shell scripts to ensure consistency and maintainability.
…tall_venv scripts Install example dependencies directly from requirements.txt across chart_artifact_job, clickhouse_metrics_job, and xdash_dashboard install_venv.sh scripts. Comment link: #985 (comment) Comment link: #985 (comment) Comment link: #985 (comment) TAG=agy CONV=df3c1c34-924a-42d3-81dc-9755d79b93f5
janzak-dev
temporarily deployed
to
xmc-nightly
September 25, 2026 07:43 — with
GitHub Actions
Inactive
janzak-dev
marked this pull request as ready for review
September 25, 2026 07:49
janzak-dev
enabled auto-merge
September 25, 2026 07:51
VLukiantsev
approved these changes
Sep 25, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
googleapis-common-protosto<1.75.4across deployment scripts, example virtual environment scripts/requirements, and SDK configs to prevent breaking changes in upstream protobuf descriptor pool registrations.Motivation & Context
Nightly run
#36084831609failed due to the release ofgoogleapis-common-protos 1.75.4on PyPI (released 2026-09-24 23:19:57 UTC). Upstream 1.75.4 regeneratedoperations_proto_pb2.pyfromoperations_proto.protoinstead ofoperations.proto, breaking descriptor pool lookup forgoogle/longrunning/operations.protowhen importing longrunning operations protos. Pinninggoogleapis-common-protos<1.75.4restores stability across runtime deployment and example job execution.Successful run
https://github.com/google/xmc/actions/runs/36109137545/job/107988362447
Key Changes
deploy/cli/install_xmanager.py): Constraingoogleapis-common-protos<1.75.4.sdks/python/xdash/pyproject.toml): Pingoogleapis-common-protos>=1.50.0,<1.75.4.googleapis-common-protos<1.75.4inexamples/*/install_venv.shscripts (chart_artifact_job,clickhouse_metrics_job,xdash_dashboard).googleapis-common-protos>=1.63.0,<1.75.4across all 13 examplerequirements.txtfiles.Assumptions
None — requirements were fully specified.
Verification & Testing
export PATH="...:$PATH" && ./.githooks/pre-commit(all pre-commit hooks passed: Buildifier, gofmt, golangci-lint, determinism, addlicense, Trivy)./tools/analyze_diff_size.py --base-ref origin/main...(diff size check passed: 0 prod lines, 0 test lines)bazel test //deploy/cli:install_xmanager_test //sdks/python/xdash/...(5/5 tests passed)Related Issues / Bugs
N/A (Resolves failure in nightly run #36084831609)
TAG=agy
CONV=df3c1c34-924a-42d3-81dc-9755d79b93f5