Repository navigation
feat(ui): align experiments data table borders, typography, and links - #956
Merged
Merged
Conversation
Add 1px solid #dadce0 (8px radius) card framing to the experiments table and align 13px header/cell typography, #f8f9fa row hover highlight, and underlined #1a73e8 title links. TAG=agy CONV=10ea5f21-5600-4e9d-91a0-f605c676b5bd
There was a problem hiding this comment.
Code Review
This pull request updates the styling of the experiments table, including container borders, header and cell padding, hover states, and link decorations. The feedback points out that hardcoded hex colors are used instead of standard Material Design CSS custom properties, which breaks themeability (such as dark mode support) for both the table elements and the cell links.
Comment link: #956 (comment) TAG=agy CONV=10ea5f21-5600-4e9d-91a0-f605c676b5bd
liutj-tech
marked this pull request as ready for review
September 22, 2026 21:56
liutj-tech
requested review from
AntonTyb
and removed request for
andrzejfudro
September 22, 2026 21:56
AntonTyb
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
1px solid #dadce0(8pxradius) card framing to the Experiments Table and aligns13pxheader/cell typography,#f8f9farow hover highlight, and underlined#1a73e8experiment title links with the prototype.(Part 5 of 8 in the scoped UI Style Alignment series corresponding to Area #5 of the Style Inconsistency Table.)
Visual Comparison (Before vs. After)
Component-Level Diff (Area #5)
📸 Full-Page Context Screenshot (Production vs. Prototype)
Motivation & Context
Brings Area #5 of
cmd/ui/into visual alignment with the Google Cloud / Material 3 prototype specification while keeping this Pull Request focused on a single cohesive component area (< 45lines of diff).Key Changes
cmd/ui/app/experiments_list_page/experiments_table/experiments_table.scss: Addborder: 1px solid #dadce0(border-radius: 8px,background-color: #ffffff) to.table-container, styleth.mat-mdc-header-cell(13px,600weight,#dadce0border) andtd.mat-mdc-cell(13px,#f1f3f4border), add#f8f9farow hover, and underline.title-cell .cell-link(#1a73e8).Assumptions
"XManager"brand title/logo and fixed200pxnon-expandable left sidenav was explicitly requested by the user — expandable drawer behavior and brand header text changes are deferred to a future change — zero impact on current routes or functionality.Verification & Testing
./tools/analyze_diff_size.py --base-ref origin/main...(well below400-line threshold)npm run format:check && npm run lint(Prettier & ESLint passed cleanly)npm run build(Angular production bundle compiled cleanly)npm test -- --watch=false --browsers=ChromeHeadlessNoSandbox(616 of 616 SUCCESS)Related Issues / Bugs
N/A
TAG=agy
CONV=10ea5f21-5600-4e9d-91a0-f605c676b5bd