Repository navigation
refactor(ci): prune legacy trigger-demo-workload naming and job references - #919
Merged
Merged
Conversation
…ences Remove deprecated trigger-demo-workload and validate-workload-results job fallbacks in nightly-failure-alert.js and align unit test fixtures with canonical workflow job IDs (run-and-verify-demo-workload, run-and-verify-examples, aggregate-results). TAG=agy CONV=df3c1c34-924a-42d3-81dc-9755d79b93f5
There was a problem hiding this comment.
Code Review
This pull request updates the nightly failure alert script and its associated tests by removing references to the obsolete 'trigger-demo-workload' and 'validate-workload-results' workflow steps from the outcome resolution logic. There are no review comments to evaluate, and I have no feedback to provide.
janzak-dev
marked this pull request as ready for review
September 18, 2026 08:38
andrzejfudro
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Context
This PR cleans up deprecated job name fallbacks (
trigger-demo-workloadandvalidate-workload-results) in.github/scripts/nightly-failure-alert.jsand aligns test fixtures in.github/scripts/nightly-failure-alert.test.jswith the active canonical workflow schema.Background & Historical Context
trigger-demo-workload.ymlwas originally introduced as a standalone launcher workflow in PR feat(examples): add multi-workunit simple job launch script and nightly workflow #847 and integrated intonightly-test-suite.ymlin PR feat(ci): add scheduled nightly test suite workflow #852 alongsidevalidate-workload-results.run-and-verify-demo-workloadin.github/workflows/nightly-test-suite.yml. While.github/workflows/trigger-demo-workload.ymlwas deleted, backwards-compatibility fallbacks were retained innightly-failure-alert.jsto ensure stability across rollout branches..github/workflows/nightly-test-suite.yml: Uses the unifiedrun-and-verify-demo-workloadsingle-job pattern where launch and verification happen in one runner without the standalone trigger step..github/workflows/nightly-examples-e2e.yml: Uses the unifiedrun-and-verify-examplesandaggregate-resultsmatrix pipeline (PR feat(ci): add unified nightly examples e2e pipeline workflow #909).The legacy standalone
trigger-demo-workloadjob name is fully obsolete and has no active producers.Key Changes
.github/scripts/nightly-failure-alert.js: Prunedtrigger-demo-workloadandvalidate-workload-resultsfallbacks inbuildAlertParams. Active resolution now exclusively checks canonical jobs:triggerOutcome:run-and-verify-demo-workloadorrun-and-verify-examplesverifyOutcome:run-and-verify-demo-workloadoraggregate-results.github/scripts/nightly-failure-alert.test.js: Updated unit test fixtures to use active job IDs (run-and-verify-demo-workload) instead of legacy names.Verification Record
node --test .github/scripts/nightly-failure-alert.test.js(31/31 passed).node --test .github/scripts/*.test.js(175/175 passed across 11 suites).bazel test //tools/nightly_tests/...(2/2 passed)../.githooks/pre-commitcleanly.trigger-demo-workloadandvalidate-workload-resultsacross the repo viagit grep.TAG=agy
CONV=df3c1c34-924a-42d3-81dc-9755d79b93f5