8000 feat(ui): add pause scheduling card and confirmation modal to Admin Panel by andrzejfudro · Pull Request #889 · google/xmc · GitHub
[go: up one dir, main page]

Skip to content

feat(ui): add pause scheduling card and confirmation modal to Admin Panel - #889

Merged
andrzejfudro merged 3 commits into
mainfrom
feat/admin-panel-pause-scheduling-ui
Sep 17, 2026
Merged

andrzejfudro merged 3 commits into
mainfrom
feat/admin-panel-pause-scheduling-ui

Conversation

@andrzejfudro
@andrzejfudro andrzejfudro commented Sep 16, 2026 •
Copy link
Copy Markdown
Collaborator

This PR intentionally skips managing the signal, network calls, error handling etc. Those will be handled in the follow up PR. This PR adds only visual representation.

Summary

Adds the Pause All Scheduling card and confirmation modal dialog to the XMC Admin Panel. This forms PR 1 (visual presentation slice) of the pause scheduling feature stack.

Key Changes

  • Scheduling Pause Card: Compact pause toggle card in the health status section with prototype-matched styling, outlined icons (play_circle / pause_circle), and native Angular Material slide toggle.
  • Confirmation Modal: Dialog prompting administrators for confirmation with clear warning cues and action-specific buttons before flipping scheduling state.
  • Scope Boundary: All network communication (pauseScheduling, resumeScheduling), loading states, and error handling are deferred to the follow-up stacked PR.
  • Tests: Added full Jasmine/Karma unit test suites and CDK harnesses for the pause button card and confirmation modal.

Preview

Inactive

image

Active

image

Confirmation modal

image

TAG=agy
CONV=c33b49d4-fef7-4401-a7d4-d5cadcef9d6e

10000

@gemini-code-assist gemini-code-assist Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a 'Pause All Scheduling' feature to the Admin Panel, allowing administrators to temporarily stop the actuator from interacting with the control plane. It adds a toggle button component, a confirmation modal, corresponding unit tests, and harness files. The review feedback suggests several improvements: implementing an Angular effect to reset the local pause state when health status is refreshed to prevent the UI from getting stuck, supporting a disabled state on the toggle button when the feature flag is disabled but scheduling is already paused, and improving modal accessibility by closing it on the Escape key press.

…anel

Add the "Pause All Scheduling" presentation card and confirmation modal
to the Admin Panel health status section. Includes responsive prototype-aligned
card styling, toggle confirmation dialog, unit tests, and CDK test harnesses.

Network calls and backend synchronization are deferred to the follow-up PR.

TAG=agy
CONV=c33b49d4-fef7-4401-a7d4-d5cadcef9d6e
@andrzejfudro
andrzejfudro force-pushed the feat/admin-panel-pause-scheduling-ui branch from 2234e12 to e949373 Compare September 16, 2026 09:39
@andrzejfudro
andrzejfudro marked this pull request as ready for review September 16, 2026 09:43
@github-actions
github-actions Bot requested a review from pachopepe September 16, 2026 09:43
Address reviewer nit by extracting modal confirmation button text into a computed signal.

Comment link: #889 (comment)
TAG=agy
CONV=c33b49d4-fef7-4401-a7d4-d5cadcef9d6e
@andrzejfudro
andrzejfudro added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit 2cd9bc4 Sep 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0