Repository navigation
feat(pausedtask): define repository interface and in-memory fake - #857
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new pausedtask package under internal/storage/spanner to manage and persist tasks intercepted during a scheduling pause. It includes the definition of the Repository interface, the PausedTask entity, an in-memory Fake implementation for testing, and comprehensive unit tests. Additionally, a new SCHEDULING_PAUSED status has been added to the WorkUnitStatus proto. Feedback is provided regarding a potential issue in fake.go where taking the address of a loop-local variable could lead to bugs, with a suggestion to allocate the timestamp on the heap instead.
andrzejfudro
force-pushed
the
feat/paused-tasks-repository
branch
2 times, most recently
from
September 11, 2026 13:51
a98575c to
510c6fe
Compare
Introduce the pausedtask.Repository interface and in-memory Fake test double. This unblocks task buffering during scheduling pause in Actuator and subsequent resumption replay workflows in ESS. TAG=agy CONV=ced76f25-77b3-448a-8da6-a1b9c94246b6
andrzejfudro
force-pushed
the
feat/paused-tasks-repository
branch
from
September 11, 2026 14:05
510c6fe to
1b96aeb
Compare
andrzejfudro
marked this pull request as ready for review
September 11, 2026 14:08
andrzejfudro
enabled auto-merge
September 11, 2026 14:51
janzak-dev
previously approved these changes
Sep 14, 2026
Removes the unused List method from the Repository interface and retains it strictly on *Fake as an in-memory inspection helper for tests. TAG=agy CONV=ced76f25-77b3-448a-8da6-a1b9c94246b6
janzak-dev
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a mocked repository for Paused Tasks. It is not called by anything yet but I add it to prepare ground for a few tasks that will use this repository - adding it now allows me to parallelize work without conflicts. I plan to defer adding real spanner integration to this repository to the last possible moment.