Repository navigation
refactor(actuator): drop XMC_MANAGED_XPROF_GCS_BUCKET env var - #840
Merged
Merged
Conversation
Remove the cluster-shared XMC_MANAGED_XPROF_GCS_BUCKET environment variable. Managed-xprof workloads now rely solely on the per-work-unit XMC_MANAGED_XPROF_GCS_OBJECT_FOLDER for their write destination; the GCS bucket is still resolved via the Actuator to derive that per-work-unit object folder. - Drop the constant and stop injecting it into workload containers. - Simplify injectManagedXprofGCSEnvVars to a single object-folder parameter. - Update actuator jobset tests accordingly. TAG=agy CONV=3723941a-65a7-4dfd-aad7-679783a54ea0
CatherineF-dev
marked this pull request as ready for review
September 9, 2026 16:11
There was a problem hiding this comment.
Code Review
This pull request removes the unused XmcEnvVarManagedXprofGCSBucket environment variable and its associated logic across the codebase, simplifying the GCS environment variable injection to only use the per-work-unit object folder path. Feedback on the changes suggests removing a redundant check for xprofObjectPath != "" inside injectManagedXprofGCSEnvVarsToContainers, as an early return guard already ensures the path is not empty.
Update test case name in TestInjectManagedXprofGCSEnvVars_AllContainers from "no bucket or object is a no-op" to "empty object is a no-op" to reflect the dropped bucket parameter. TAG=agy CONV=0b286d04-a552-409e-9c9e-d0f05660bab1
AntonTyb
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the cluster-shared XMC_MANAGED_XPROF_GCS_BUCKET environment variable. Managed-xprof workloads now rely solely on the per-work-unit XMC_MANAGED_XPROF_GCS_OBJECT_FOLDER for their write destination; the GCS bucket is still resolved via the Actuator to derive that per-work-unit object folder.
TAG=agy
CONV=3723941a-65a7-4dfd-aad7-679783a54ea0