Repository navigation
docs(rules): add harness encapsulation and sanitization rules, support pr title update - #743
Merged
Merged
Conversation
…tle update Update engineering rules and review tooling following iterative reflection: - Add Angular CDK Component Harness Standards to typescript_javascript.md enforcing 100% harness encapsulation and DRY traversal helpers in component tests. - Add Environment & URL Sanitization Policy to github_authoring_and_prs.md prohibiting internal hostnames, cluster names, and test project IDs in PR descriptions and public commit messages. - Enhance tools/pr_review/update_pr_description.py with optional --title argument, allowing title and/or body updates via GitHub REST API. - Add unit test suite in update_pr_description_test.py and register py_test target in BUILD.bazel. TAG=agy CONV=18ec6201-6e57-42c2-8346-1a62d59c3638
There was a problem hiding this comment.
Code Review
This pull request updates the update_pr_description.py tool to support updating a GitHub Pull Request's title in addition to its body, adds corresponding unit tests, and updates the repository rules and documentation. The review feedback suggests wrapping the file-reading logic in a try-except block to handle potential OSErrors gracefully, and resolving an inconsistency in how the title and body arguments are validated.
VLukiantsev
marked this pull request as ready for review
September 2, 2026 12:30
…g title - Wrap body_path.read_text in try-except OSError raising HandledError - Check args.title with is not None to permit empty string titles - Add unit tests for OSError handling and empty string title Comment links: - #743 (comment) - #743 (comment)
VLukiantsev
enabled auto-merge
September 2, 2026 12:37
janzak-dev
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates engineering guidelines and review tooling following iterative reflection:
typescript_javascript.mdenforcing 100% harness encapsulation (prohibiting raw DOM selectors/getElin test specs) and internal DRY traversal helpers.github_authoring_and_prs.mdprohibiting specific cluster names, internal domains, and test project IDs in PR descriptions.tools/pr_review/update_pr_description.pywith an optional--titleflag to update PR titles via the reliable GitHub REST API, accompanied by a comprehensive unit test suite inupdate_pr_description_test.py.Key Changes
.agents/rules/languages/typescript_javascript.md: Added CDK Component Harness standards..agents/rules/github_authoring_and_prs.md: Added Environment & URL Sanitization Policy.tools/pr_review/update_pr_description.py: Added--titlesupport via GitHub REST API PATCH endpoint.tools/pr_review/update_pr_description_test.py: Added 11 unit tests covering PR identifier parsing, validation errors, and title/body updates.tools/pr_review/BUILD.bazel: Registeredupdate_pr_description_test.Assumptions
Verification & Testing
bazel test //tools/pr_review/...(9/9 targets passed).python3 -m unittest tools/pr_review/update_pr_description_test.py(11/11 passed).🧪 Trajectory & Outcome Benchmark Results
📊 Trajectory & Outcome Comparison Report
Pillar 1: Trajectory Telemetry (Efficiency & Behavior)
Pillar 2: Outcome & Quality Evaluation
🎯 LLM-as-a-Judge Outcome Scorecard
... in project ...-env, zone us-central1-c) and raw log outputs into PR description.getDataRows(),getUrlsCell()) avoiding raw DOM selectors.🏆 Final Benchmark Verdict:
PASSEDRationale: The candidate rules successfully eliminated environment leaks in drafted PR descriptions and enforced high-quality Angular CDK testing harness standards and DRY principles, while maintaining clean error-free execution and reducing overall context footprint.
TAG=agy
CONV=18ec6201-6e57-42c2-8346-1a62d59c3638