Repository navigation
fix(metrics): add clickhouse schema initialization step and set worker permissions - #681
Merged
Merged
Conversation
…r permissions - Add Step 6 to deploy/addons/metrics/clickhouse/README.md to document applying deploy/clickhouse/schema.sql after ClickHouse Helm installation. - Update examples/clickhouse_metrics_job/Dockerfile to set world-readable permissions (chmod 755 /app /app/worker.py) so the container runs reliably under non-root user UID 1000 in GKE without Errno 13 permission denied. TAG=agy CONV=2181645e-ca2d-4226-90b5-e4a821928f9d
There was a problem hiding this comment.
Code Review
This pull request adds documentation for initializing the ClickHouse metrics schema and updates file permissions in the metrics job Dockerfile. The review feedback suggests improving the documentation by targeting the StatefulSet instead of a hardcoded pod name, and applying the principle of least privilege by setting the Python script permissions to 644 instead of 755, as it is executed directly via the python3 interpreter.
…missions to 644 - Target statefulset/my-clickstack-clickhouse-clickhouse-0-0 in deploy/addons/metrics/clickhouse/README.md Step 6. - Update examples/clickhouse_metrics_job/Dockerfile to set chmod 644 on worker.py. TAG=agy CONV=2181645e-ca2d-4226-90b5-e4a821928f9d
andrzejfudro
marked this pull request as ready for review
August 31, 2026 14:30
AntonTyb
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small findings from recent test deployment.