Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSLX bytecode accepts
map([[x, !x]], array_rev)andmap([[x, !x]], array_size), but IR conversion rejected both builtin names. Teach the converter to reverse each inner array or emit its length as au32when building the function applied bymap.Add two regression proofs to
//xls/dslx/tests:map_prove_quickcheck_test. They check the results across element types and distinguish inner lengths from outer lengths.Both proofs reproduced the converter errors before the fix and passed afterward. Clang-format, build-cleaner, Bant, and buildifier passed. The optimized
//xls/...wildcard sweep passed all 2,206 selected tests. It excludedcontrib,dev_tools,visualization, and five test targets with OpenROAD, Yosys, or Clang build dependencies.