Repository navigation
Empty maktaba#buffer#Overwrite() sometimes hangs vroom #84
Description
For some reason, I notice a hang of ~2 seconds when I execute a vroom file that contains the following:
:source /home/dbarnett/.vim/vim-addons/maktaba/bootstrap.vim
:call maktaba#buffer#Overwrite(1, 1, [])It only triggers with an empty list. Interestingly, it also seems to be sensitive to the state of :messages as well, and just adding :set nocompatible at the beginning of the file above to get rid of the Maktaba does not support vi compatibility error makes the hang disappear. I isolated the delay to the python code vim.current.buffer[i1+offset:i2+offset] = lines[j1:j2] from maktaba, and in the process determines it only affects the python implementation and not the vimscript fallback implementation. When I Ctrl-C during the hang, I see a vroom traceback in self.env.vim.GetMessages.
This condition also seems to manifest on Travis CI builds as failures like Error formatting file: Vim(let):E677: Error writing temp file. Example: https://travis-ci.org/google/vim-codefmt/jobs/48454624
Activity
Avoid formatting empty buffers due to hangs/errors (google/vroom#84)