8000 Handle edge case when all labels are NaN. by copybara-service[bot] · Pull Request #1162 · google/vizier · GitHub
[go: up one dir, main page]
Skip to content

Handle edge case when all labels are NaN. #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Sep 11, 2024
Merged

Handle edge case when all labels are NaN. #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions vizier/_src/algorithms/designers/gp/output_warpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,11 +455,18 @@ class InfeasibleWarperComponent(OutputWarper):
nearly equal to v_infeasible.
"""

_shift: float = attr.field(default=np.nan)
_shift: Optional[float] = attr.field(default=None)

def warp(self, labels_arr: types.Array) -> types.Array:
labels_arr = _validate_labels(labels_arr)
labels_arr = labels_arr.flatten()

if np.isnan(labels_arr).all():
# Edge case when all values are NaN.
self._shift = np.nan
labels_arr[:] = 0
return labels_arr[:, np.newaxis]

labels_range = np.nanmax(labels_arr) - np.nanmin(labels_arr)
warped_bad_value = np.nanmin(labels_arr) - (0.5 * labels_range + 1)
num_feasible = labels_arr.size - np.isnan(labels_arr).sum()
Expand All @@ -481,7 +488,7 @@ def warp(self, labels_arr: types.Array) -> types.Array:
return labels_arr[:, np.newaxis]

def unwarp(self, labels_arr: types.Array) -> types.Array:
if np.isnan(self._shift):
if self._shift is None:
raise ValueError('warp() needs to be called before unwarp() is called.')
return labels_arr - self._shift

Expand Down
10 changes: 10 additions & 0 deletions vizier/_src/algorithms/designers/gp/output_warpers_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,16 @@ def test_warper_removes_nans(self):
labels_warped_infeasible = warper_infeasible.warp(labels)
self.assertEqual(np.isnan(labels_warped_infeasible).sum(), 0)

def test_all_nans(self):
warper_infeasible = output_warpers.InfeasibleWarperComponent()
labels = np.array([[np.nan], [np.nan], [np.nan], [np.nan]])
labels_warped_infeasible = warper_infeasible.warp(labels)
expected = np.array([[0.0], [0.0], [0.0], [0.0]])
np.testing.assert_equal(labels_warped_infeasible, expected)

unwarped = warper_infeasible.unwarp(labels_warped_infeasible)
np.testing.assert_equal(unwarped, labels)

def test_known_arrays(self):
# TODO: Add a couple of parameterized test cases.
self.skipTest('No test cases provided')
Expand Down
0