Repository navigation
Update Pytypes after recent changes to typing in JAX/Numpy, and following our decision to use more specific types (instead of chex.Array) where possible. - #624
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_521533192
branch
10 times, most recently
from
April 4, 2023 01:45
110f31f to
6fc16c0
Compare
copybara-service
Bot
force-pushed
the
test_521533192
branch
5 times, most recently
from
April 5, 2023 14:55
5771a1a to
f901047
Compare
copybara-service
Bot
force-pushed
the
test_521533192
branch
from
April 5, 2023 15:05
f901047 to
c402c81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can
32A1
be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Pytypes after recent changes to typing in JAX/Numpy, and following our decision to use more specific types (instead of chex.Array) where possible.
Array = Union[np.ndarray, jax.Array]in place of chex.Array/ArrayLike, because the latter includes Numpy scalars which cause type errors when properties likeshapeare accessed.