Repository navigation
Normalize loss value by the number of observations only when using SGD-based GP hparam optimizers (so a consistent learning rate can be used regardless of the number of observations). Previously, this was baked into the loss function definition; now that we're using L-BFGS-B by default, this is unnecessary and possibly confusing. - #602
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_518963849
branch
3 times, most recently
from
March 31, 2023 19:40
986326a to
3188217
Compare
…D-based GP hparam optimizers (so a consistent learning rate can be used regardless of the number of observations). Previously, this was baked into the loss function definition; now that we're using L-BFGS-B by default, this is unnecessary and possibly confusing. PiperOrigin-RevId: 520990026
copybara-service
Bot
force-pushed
the
test_518963849
branch
from
March 31, 2023 19:47
3188217 to
5557250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize loss value by the number of observations only when using SGD-based GP hparam optimizers (so a consistent learning rate can be used regardless of the number of observations). Previously, this was baked into the loss function definition; now that we're using L-BFGS-B by default, this is unnecessary and possibly confusing.