Repository navigation
Pass an allocation index to MemoryDebugAnnotation::pending_shape_func. - #3679
Merged
Merged
Conversation
`MemoryDebugAnnotation::pending_shape_func` currently takes no arguments and can only describe a single pending tensor allocation, preventing batched allocation paths from lazily formatting distinct per-buffer shapes through thread-local debug annotations without passing shape objects through lower-level byte-buffer APIs. Update `MemoryDebugAnnotation::pending_shape_func` (and `DefaultPendingShapeFunc`) to accept a `size_t` allocation index (`0` for single-tensor allocations), add indexed `ScopedMemoryDebugAnnotation` constructors while retaining delegating zero-argument constructors for existing callers, and pass index `0` at existing single-allocation call sites. PiperOrigin-RevId: 1016029870
copybara-service
Bot
force-pushed
the
test_1014903409
branch
from
November 7, 2026 02:36
d6a5369 to
fbb84e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass an allocation index to MemoryDebugAnnotation::pending_shape_func.
MemoryDebugAnnotation::pending_shape_funccurrently takes no arguments and can only describe a single pending tensor allocation, preventing batched allocation paths from lazily formatting distinct per-buffer shapes through thread-local debug annotations without passing shape objects through lower-level byte-buffer APIs.Update
MemoryDebugAnnotation::pending_shape_func(andDefaultPendingShapeFunc) to accept asize_tallocation index (0for single-tensor allocations), add indexedScopedMemoryDebugAnnotationconstructors while retaining delegating zero-argument constructors for existing callers, and pass index0at existing single-allocation call sites.