Repository navigation
Add TraceMeFilter::kTraceHostEnqueueCallback = 1 in trace_filter_utils.h, and clear that bit (bit 1, mask 0x2) in kTraceMeDefaultFilterMask in traceme.h using a new kTraceMeHostEnqueueCallbackFilter constant with the same value. traceme.h cannot depend on trace_filter_utils.h, so traceme_recorder_test checks with a static_assert that the two stay equal. - #3677
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_1011286453
branch
2 times, most recently
from
November 9, 2026 06:50
1a78346 to
9c9ed68
Compare
TraceMeFilter::kTraceHostEnqueueCallback = 1 in trace_filter_utils.h and clear bit 1 (~(1ULL << tsl::profiler::kTraceHostEnqueueCallback)) in kTraceMeDefaultFilterMask in traceme.h.TraceMeFilter::kTraceHostEnqueueCallback = 1 in trace_filter_utils.h, and clear that bit in kTraceMeDefaultFilterMask in traceme.h using a new kTraceMeHostEnqueueCallbackFilterBit constant. traceme.h cannot depend on trace_filter_utils.h, so traceme_recorder_test checks with a static_assert that the two stay equal.
…tils.h`, and clear that bit (bit 1, mask `0x2`) in `kTraceMeDefaultFilterMask` in `traceme.h` using a new `kTraceMeHostEnqueueCallbackFilter` constant with the same value. `traceme.h` cannot depend on `trace_filter_utils.h`, so `traceme_recorder_test` checks with a `static_assert` that the two stay equal. Sessions configured with `host_traceme_filter_mask = (1ULL << kTraceHostEnqueueCallback)` record only `TraceMe` events tagged with that bit. Sessions without a filter or with the `kTraceMemory` filter record the same events as before, including the tagged ones. `traceme_recorder_test` covers both cases. PiperOrigin-RevId: 1011286453
copybara-service
Bot
force-pushed
the
test_1011286453
branch
from
November 9, 2026 07:05
9c9ed68 to
b1e6fdf
Compare
TraceMeFilter::kTraceHostEnqueueCallback = 1 in trace_filter_utils.h, and clear that bit in kTraceMeDefaultFilterMask in traceme.h using a new kTraceMeHostEnqueueCallbackFilterBit constant. traceme.h cannot depend on trace_filter_utils.h, so traceme_recorder_test checks with a static_assert that the two stay equal.TraceMeFilter::kTraceHostEnqueueCallback = 1 in trace_filter_utils.h, and clear that bit (bit 1, mask 0x2) in kTraceMeDefaultFilterMask in traceme.h using a new kTraceMeHostEnqueueCallbackFilter constant with the same value. traceme.h cannot depend on trace_filter_utils.h, so traceme_recorder_test checks with a static_assert that the two stay equal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
TraceMeFilter::kTraceHostEnqueueCallback = 1intrace_filter_utils.h, and clear that bit (bit 1, mask0x2) inkTraceMeDefaultFilterMaskintraceme.husing a newkTraceMeHostEnqueueCallbackFilterconstant with the same value.traceme.hcannot depend ontrace_filter_utils.h, sotraceme_recorder_testchecks with astatic_assertthat the two stay equal.Sessions configured with
host_traceme_filter_mask = (1ULL << kTraceHostEnqueueCallback)record onlyTraceMeevents tagged with that bit. Sessions without a filter or with thekTraceMemoryfilter record the same events as before, including the tagged ones.traceme_recorder_testcovers both cases.