[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced io/ioutil with "os / io" package. #17792

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Replaced io/ioutil with "os / io" package. #17792

merged 1 commit into from
Nov 17, 2022

Conversation

yanggangtony
Copy link
Contributor

Signed-off-by: yanggang gang.yang@daocloud.io

/kind cleanup
We should clean all io/util package according the url: https://go.dev/doc/go1.16#ioutil

@yanggangtony yanggangtony requested a review from a team as a code owner November 13, 2022 08:44
@codecov
Copy link
codecov bot commented Nov 14, 2022 •
edited
Loading

Codecov Report

Merging #17792 (551fdd1) into main (a47e175) will decrease coverage by 0.02%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17792      +/-   ##
==========================================
- Coverage   66.54%   66.51%   -0.03%     
==========================================
  Files         997      997              
  Lines      106730   106724       -6     
  Branches     2597     2589       -8     
==========================================
- Hits        71019    70990      -29     
- Misses      31791    31813      +22     
- Partials     3920     3921       +1
Flag Coverage Δ
unittests 66.51% <55.55%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/api/chart_repository.go 34.10% <0.00%> (ø)
src/jobservice/hook/hook_client.go 54.09% <0.00%> (ø)
src/pkg/reg/adapter/artifacthub/chart_registry.go 19.23% <0.00%> (ø)
src/pkg/reg/adapter/dockerhub/client.go 30.30% <0.00%> (ø)
src/pkg/reg/adapter/googlegcr/adapter.go 47.40% <0.00%> (ø)
src/pkg/reg/adapter/helmhub/chart_registry.go 0.00% <0.00%> (ø)
src/pkg/reg/adapter/helmhub/client.go 0.00% <0.00%> (ø)
src/pkg/reg/adapter/jfrog/adapter.go 59.68% <0.00%> (ø)
src/pkg/reg/adapter/quay/adapter.go 30.15% <0.00%> (ø)
src/pkg/scan/job.go 30.47% <0.00%> (ø)
... and 58 more

@MinerYang MinerYang added the release-note/ignore-for-release Do not include PR or Issue for release notes label Nov 14, 2022
@MinerYang
Copy link
Contributor

Could you resolve the conflict above?

@OrlinVasilev OrlinVasilev added release-note/update Update or Fix and removed release-note/ignore-for-release Do not include PR or Issue for release notes labels Nov 14, 2022
@yanggangtony
Copy link
Contributor Author

Could you resolve the conflict above?

@MinerYang
Hey ,I had resolved the conflict code.

@yanggangtony
Copy link
Contributor Author

Oh,harbor/src/core/api/harborapi_test.go in a mass..
image
image

@wy65701436 @MinerYang
Replaced io/ioutil with "os / io" package.
551fdd1 
Signed-off-by: yanggang <gang.yang@daocloud.io>

update typo

Signed-off-by: yminer <yminer@vmware.com>
MinerYang
MinerYang approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor
@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit 0f4e2da into goharbor:main Nov 17, 2022
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
@wy65701436
Replaced io/ioutil with "os / io" package. (goharbor#17792)
581652a 
Signed-off-by: yanggang <gang.yang@daocloud.io>

update typo

Signed-off-by: yminer <yminer@vmware.com>

Signed-off-by: yminer <yminer@vmware.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinerYang MinerYang MinerYang approved these changes

@zyyw zyyw zyyw approved these changes

Assignees

@zyyw zyyw

@MinerYang MinerYang

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yanggangtony @MinerYang @zyyw @OrlinVasilev @wy65701436