8000 Remove redundant quotes with IgnoreInlineComment=true · Issue #99 · go-ini/ini · GitHub
[go: up one dir, main page]
Skip to content

Remove redundant quotes with IgnoreInlineComment=true #99

New issue
New issue
Closed
Closed
Remove redundant quotes with IgnoreInlineComment=true#99

Description

@ziflex
ziflex
opened on Apr 22, 2017

Hi there,

Finally, the lib can ignore inline comments. It's great and works like a charm. But can we now remove redundant quotes for values that contain ; or # symbols when IgnoreInlineComment is set to true?

Specifically, here

ini/ini.go

Line 502 in 1730955

} else if strings.ContainsAny(val, "#;") {

Activity

  1. unknwon
    added a commit that references this issue on May 18, 2017

    ini: do not outout back quotes if IgnoreInlineComment enabled (#99)

    36da989
  2. unknwon
    added
    bug
    on May 18, 2017

  3. unknwon commented on May 18, 2017

    @unknwon
    Member

    Thanks for the report! Please update and try again!

  4. unknwon
    added
    feedback needed
    on May 18, 2017

  5. ziflex commented on May 18, 2017

    @ziflex
    ziflex
    on May 18, 2017
    Author

    Fixed, great! Thank you!

  6. ziflex
    closed this as completedon May 18, 2017
  7. unknwon
    removed
    feedback needed
    on May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      0