add {{TEST_MINIO_ENDPOINT}} for local testing "with/without" docker + fix pgsql testing doc #32105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th docker outside from docker, alter docu accordingly + fix pgsql testing docu
|
have you raised an issue first when you found out something so that maintainers can have chat over it. it will be helpful to raise an issue first (if not ) ! and how to reproduce it ? Thaks |
Hi, sry I haven't raised an issue (yet). |
lunny
approved these changes
Oct 2, 2024
techknowlogick
approved these changes
Oct 3, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 8, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Allow filtering PRs by poster in the ListPullRequests API (go-gitea#32209) Fix bug when there are multiple triggers with workflow dispatch (go-gitea#32200) [skip ci] Updated licenses and gitignores [skip ci] Updated translations via Crowdin Upgrade htmx to 2.0.3 (go-gitea#32192) Enhance USER_DISABLED_FEATURES to allow disabling change username or full name (go-gitea#31959) [skip ci] Updated translations via Crowdin Add support for searching users by email (go-gitea#30908) Fix PR creation on forked repositories (go-gitea#31863) [skip ci] Updated translations via Crowdin Fixed race condition when deleting documents by repoId in ElasticSearch (go-gitea#32185) add {{TEST_MINIO_ENDPOINT}} for local testing "with/without" docker + fix pgsql testing doc (go-gitea#32105) [skip ci] Updated translations via Crowdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while testing i found out that testing locally as documented in the changed README.md for pgsql isn't working because of the minio dependency. reworked this to by default be still docker, but allow for for local with only minio in docker and testing on bare metal.
also depending on this: fixed docs for running pgsql test
Closes: #32168 (by changing documentation for pgsql tests)
Closes: #32169 (by changing documentation, Makefile & pgsql.ini.tmpl: adding {{TEST_MINIO_ENDPOINT}})
sry for the combined pr, but when testing I ran into this issue and first thought they were related and now finally address the same problem: not beeing able to run pgsql integration tests as described in the according README.md