Adjust automerge buttons to reduce the steps and also fix cannot do automerge if there is only one mergestyle #31917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utomerge if there is only one mergestyle
wxiaoguang
reviewed
Aug 26, 2024
| @@ -22,6 +22,7 @@ export default { | |||
| mergeTitleFieldText: '', | |||
| mergeMessageFieldText: '', | |||
| hideAutoMerge: false, | |||
| name: '', | |||
There was a problem hiding this comment.
That's really a bad design, a quite hacky patch to the existing code base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32448
This PR added the same clock icon on the merge button if there is only one merge style to allow auto-merge.
cancelbutton but hide merge directly buttons. That means users have to cancel auto-merge first and then do manually merge operation. The behaviour will keep consistent as Github's .