Fix Workflow names instead of workflow file name #31474
Conversation
| {{- end -}} | ||
| {{$CurWorkflow := $.CurWorkflow}} | ||
| {{$WorkflowName := .Workflow.Name}} | ||
| {{with .ActionRun}} |
There was a problem hiding this comment.
The variable shadowing is more complex now. And the name Run also seems ambiguous
I think it's better to do so:
{{range $run = .WorkflowActionRuns}}
{{$actionRun := $run.ActionRun}}
{{$workflow = $run.Workflow}}
{{$actionRun.Title}}
...
There was a problem hiding this comment.
Thanks for the idea, I did the changes.
I tested in GitHub actions and they show the full path to the file when workflow name is absent, e.g. |
|
IIRC, GitHub has some bugs of display workflow name. That’s why no one fix this issue for a long time I think. |
|
Do you have any idea which special cases I should check or where I should look for them? |
|
I still remember the details of one test I did. And I tested it in this PR. The result is as my thought. For example, you have 2 branches, and the workflow files have same file name, but the workflow names are different. But in test branch, the workflow name is But they are all detected as the workflow So actually, the logic is still based on the file name, not the workflow name defined in the yml file. IIRC, this is caused by the original design of Gitea Action, if we want to use workflow names instead of file names, |
|
Stale for long time |
Fixes #31458 and maybe #25912
I added the name from the YAML file to the workflow object. If there is no name in the file, the name remains the filename.
I created an object to connect the run and workflow together, which was necessary to show workflow name in action run list.
(Easier to review with disabled whitespace changes, unfortunately there is a lot of them in runs_list.tmpl :( )