Repository navigation
Conversation
… instead of its former parent's handler
xsistens
force-pushed
the
fix/ui-dispatch-removed-element
branch
from
October 25, 2026 12:57
e7d68af to
0724ba1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2200
Problem
When the server dispatches a client event and the next path segment names no current child, the event bubbles to the enclosing element as if the user had clicked it. This happens in
dispatch(an element with neither a reactive nor a static child for the segment) and in the fragment handle built bywalkStatic(a key or index matching no child, as for an item aforeachhas just removed). Since every rendered child is normalized into one of those entries, such a segment can only name an element removed since the client sent the event.Solution
Both branches now return
falseand run no handler. Children that are still rendered but have no handlers of their own keep bubbling, since they reach dispatch through their own handle.Notes
UIEventWiringTestcover a removed static child and a removedforeachitem, each next to a handler-less element that must still bubble. Both fail onmainwith(1, 2)toggles and pass with the fix.foreachcan still resolve a stale index to a different item; that is out of this change's reach and noted in the issue.