8000 REL-4855 Don't move the ifus on calibrations by cquiroz · Pull Request #2817 · gemini-hlsw/seqexec · GitHub
[go: up one dir, main page]

Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8000
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,7 @@ sealed trait GhostConfig extends GhostLUT {
baseConfiguration |+| slitMaskConfiguration |+| (
if (!isScience(obsType)) {
// as per REL-4855 we move ifus to focus for calibrations
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it moves the IFUs to focus or it doesn't?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. This worked anyway because calibrations are always unguided but I'll restore the call to be consistent

ifuCalibration |+| channelConfig |+| moveIFUToFocus
svCalib |+|
ifuCalibration |+| channelConfig |+| moveIFUToFocus |+| svCalib |+|
GhostConfig.fiberConfig1(fiberAgitator1) |+|
GhostConfig.fiberConfig2(fiberAgitator2)
} else
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

package seqexec.server.ghost

import cats.Applicative
import cats.effect.Sync
import cats.syntax.all._
import giapi.client.commands.Configuration
Expand Down Expand Up @@ -53,7 +54,12 @@ object GhostController {
value <- client.guidingState
idle <- isAGIdle
finalConfig = baseConfig |+| config.moveIFUToFocus.when(_ => idle)
_ <- Logger[F].debug(s"Guiding check with value: $value isGuiding off: $idle")
_ <- Logger[F].info(
s"GHOST Guiding state value: ${value.getOrElse("None")}, isGuiding idle: $idle"
)
_ <- if (idle)
Logger[F].info("Seqexec will send a MOVE_TO to GHOST IFU bFocus and rFocus")
else Applicative[F].unit
_ <- Logger[F].debug(pprint.apply(finalConfig).toString)
} yield finalConfig

Expand Down
2 changes: 1 addition & 1 deletion project/Settings.scala
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ object Settings {
val gmpCommandRecords = "0.7.7"
val acm = "0.1.1"
val giapi = "1.1.7"
val giapiScala = "0.3.0"
val giapiScala = "0.3.1"
val giapiJmsUtil = "0.5.7"
val giapiJmsProvider = "1.6.7"
val giapiCommandsClient = "0.2.7"
Expand Down
Loading
0