Repository navigation
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GMP ran on Apache Felix with a dead tooling stack (pax-runner 1.9, Felix 5.4, pax-logging, pax-web) that made it hard to move beyond java 8.
We didn't use much of osgi capabilities but we are stuck with a dead technology. This PR removes OSGi entirely
gmp still builds and runs on Java 8 but we may move beyond than in the next PRs
What changed
Composition root: The 33 hand-written
BundleActivators andServiceTrackers are replaced by one hand-wiredGmpAppin the newgmp-mainmodule. Components are constructed in dependency order. Whiteboard patterns become explicit lists.Configuration: The
conf/services/*.cfgfiles and the per-instrument overlays underinstances/are unchanged. A small loader reads them once at startup, expands${var}from system properties, and feeds the composition root.Logging: The 148 files using
java.util.loggingare untouched. pax-logging is replaced by thejul-to-slf4jbridge plus logback.conf/logback.xmlreproduces the oldgmp.loglocation, daily rollover and line format, so existing log tooling keeps working.Distribution: Same tar.gz and RPM shape:
lib/*.jar+conf/+ launcher.start.shandgmp-server-ctl.shreplace pax-runner. One binary serves every instrument; thegpi,ghostandigrins2profiles only select the config overlay.Removed: All
osgi/packages,maven-bundle-pluginand the pax/felix dependencies, the Pax Examintegration-testsmodule, the staleintegrationtests/directory, andgpi/gpi-observation-status.