Repository navigation
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Collaborator
Author
|
Closing this PR in favor of #864. Even if we have to pull grackle-core, it's a better option than having our own implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the string manipulation in the
gqlmacro with a small lexer for the GraphQLlexical grammar (spec §2.1: punctuators, names, numbers, strings incl. block strings and
escapes, comments) and does the spliced-subquery caller-check on tokens.
Fixes two holes in the previous approach: the operation header was located by the first
(, so afragmentwith field arguments placed before the operation was mistaken for it(or, with a brace guard, hid it), losing the declared variables and falsely rejecting a
spliced subquery; and strings/comments were not understood at all.
Behavior change: a lexical error in a
gqldocument (unterminated string, stray character)is now a compile error.
GraphQLDocument.unsafeFromStringremains the escape hatch.Groundwork for #853, which will add the unused-variable/fragment warnings as token walks.