Repository navigation
Fix stale connection IDs in WebSocket client state machine - #840
Merged
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
hugo-vrijswijk
force-pushed
the
fix/f13-f18-stale-connection-id
branch
from
September 4, 2026 10:54
419c2aa to
5a8564d
Compare
Prevent stale `connect` and `initialize` results from being applied to the current connection when the state has advanced to a later connection ID. In `doConnect`, add a guard to compare the connection ID from the async result with the current state's ID. Drop stale results and close their sockets in the background to prevent leaks. In `doInitialize`, add a guard to stop fibers from a replaced connection from racing the current fiber. Adds test suite to verify stale connections are dropped and their sockets are closed without causing errors.
hugo-vrijswijk
force-pushed
the
fix/f13-f18-stale-connection-id
branch
from
September 4, 2026 10:58
5a8564d to
8aaabca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent stale
connectandinitializeresults from being applied to the current connection when the state has advanced to a later connection ID.In
doConnect, add a guard to compare the connection ID from the async result with the current state's ID. Drop stale results and close their sockets in the background to prevent leaks.In
doInitialize, add a guard to stop fibers from a replaced connection from racing the current fiber.Adds test suite to verify stale connections are dropped and their sockets are closed without causing errors.