Repository navigation
Remove GET support from the HTTP backends - #830
Merged
Merged
Conversation
Every GraphQL request now goes out with POST. Changes: - `FetchMethod`, the GET branch and `buildGetUri` are gone. `FetchJsBackend[F]()` takes no method argument. - `Http4sHttpBackend` sets POST on the request. The method of the base request is ignored. `Http4sHttpClient` already built a POST request. - `FetchJsBackendSuite`, which only tested `buildGetUri`, is deleted. - Both backend suites now assert that the request goes out with POST.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every GraphQL request now goes out with POST.
Changes:
FetchMethod, the GET branch andbuildGetUriare gone.FetchJsBackend[F]()takes no method argument.Http4sHttpBackendsets POST on the request. The method of the baserequest is ignored.
Http4sHttpClientalready built a POST request.FetchJsBackendSuite, which only testedbuildGetUri, is deleted.