Repository navigation
Conversation
sipayRT
approved these changes
Oct 20, 2026
|
|
||
| expect(component.getByRole('link', {name: 'External link'}).getAttribute('href')).to.equal('https://example.com/a'); | ||
|
|
||
| for (const id of ['b', 'a', 'empty']) { |
Member
There was a problem hiding this comment.
you don't need to check b → a here — you have already checked a state above. So in this case you can simplify this part to something like:
const selectResult = (id: string): void => {
act(() => {
store.dispatch(setCurrentTreeNode({browserId: id, treeNodeId: id}));
});
};
selectResult('b');
expect(component.getByRole('link', {name: 'External link'})).to.have.attribute('href', 'https://example.com/b');
selectResult('empty');
expect(component.queryByText('External link')).to.not.exist;
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Badge links can retain the previous result's URLs when switching results without changing the page URL or base host. Include
suite.attachmentsin theTestStatusBarmemo dependencies so the badges update with the selected result.Add a regression test that switches A → B → A and then selects a result without badges. It verifies both URL updates and removal of stale badges. The test fails on the original implementation and passes with this fix.
Closes #817.
Validation
npm test: lint, 711 Node unit tests, 854 jsdom unit tests, and type checks passed on Node.js 20.20.2.npm run build:client: passed.Docker-based E2E and component browser suites were not run locally.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.