8000 8000 feat(config): add support for parallelWorkersLimit config option by thers · Pull Request #970 · gemini-testing/gemini · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

feat(config): add support for parallelWorkersLimit config option - #970

Merged
j0tunn merged 1 commit into
gemini-testing:masterfrom
thers:feature/parallel-workers-limit
Jul 25, 2019
Merged

feat(config): add support for parallelWorkersLimit config option#970
j0tunn merged 1 commit into
gemini-testing:masterfrom
thers:feature/parallel-workers-limit

Conversation

@thers
@thers thers commented Jun 24, 2019
Copy link
Copy Markdown
Contributor

Allows to limit maximum amount of workers run in parallel during testing.
Should help running tests on servers with a lot of cpu cores (i.e. CI agent), as worker-farm (that is used for managing workers) use os.cpus().length as a default value

@j0tunn
j0tunn commented Jun 25, 2019 •
edited
Loading
Copy link
Copy Markdown
Contributor

Hi. hermione has the same option named workers: https://github.com/gemini-testing/hermione#workers
It would be nice to name this option consistent with hermione.

Another question: why don't you use hermione instead of gemini? gemini will be deprecated soon.

@thers
thers commented Jun 25, 2019
Copy link
Copy Markdown
Contributor Author

We have a lot of tests built on top of gemini and even though we'll most likely switch to hermione eventually, for a now it is adequate to add this config option to fix our current issue. I named it after "similar" parallelLimit and I doubt it should have similarities with hermione config as there're not much already. If you insist on renaming then sure, will do, just let me know about it.

@j0tunn
j0tunn commented Jun 25, 2019
Copy link
Copy Markdown
Contributor

I named it after "similar" parallelLimit

parallelLimit is about browser sessions, not about workers. So no, these options are not similar at all. And I think you should be interested in similarities with hermione config here if you plan to switch to hermione eventually.

j0tunn
j0tunn suggested changes Jun 25, 2019
View reviewed changes
Comment thread lib/state-processor/state-processor.js Resolved
Comment thread lib/state-processor/state-processor.js Resolved
Comment thread doc/config.md Resolved
Alexander Kukhta
feat(config): add support for workers config option
d7b7710 
Allows to limit maximum amount of workers run in parallel during testing.
Should help running tests on servers with a lot of cpu cores (i.e. CI agent), as worker-farm (that is used for managing workers) use os.cpus().length as a default value
@thers
thers commented Jul 24, 2019
Copy link
Copy Markdown
Contributor Author

@j0tunn ping

@j0tunn
j0tunn merged commit 6596b8b into gemini-testing:master Jul 25, 2019
@j0tunn
j0tunn commented Jul 25, 2019
Copy link
Copy Markdown
Contributor

gemini@7.5.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@j0tunn j0tunn j0tunn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thers @j0tunn
0